> On 12 Dec 2017, at 20:15, Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Lars Schneider <larsxschneider@xxxxxxxxx> writes: > >>> You're right, it's my first time using travis CI and I got confused >>> about how the .travis.yml works, thanks for catching that. Will >>> re-phrase the commit message. >> >> Szeder is spot on. If you fix up the message, then this patch looks >> perfect! Pragmatic (= very good!) idea to combine GITTEXT_POISON with >> GIT_TEST_SPLIT_INDEX :-) > > I am failing to guess the real intent of the smiley here. No real reason. I was just happy to see that Travis CI seems to be useful for the Git project. > If split-index code is so easy to break, I do not think it is a good > idea to combine it into the poison build. In fact, the poison test > is useless on a codebase where other/real breakages are expected to > exist, because it is about seeing messages meant for non-humans are > not passed to the _() mechanism by sloppy coding, and the way it > does so is to corrupt all the messages that come through the _() > mechanism. If we do not even produce a message when a correct code > _should_ produce one, poison test would catch nothing useful. > > I wonder if it makes more sense to update ci/run-tests.sh so that > its final step is run twice with different settings, like so? Agreed - I didn't think it through. Let's keep it separate then. I think your solution points into the right direction. Right now we have the following test matrix: 1. Linux - clang 2. Linux - gcc 3. Mac - clang 4. Mac - gcc 5. Linux - gcc - GET_TEXT_POISION 6. Linux - gcc - 32bit 7. Windows AFAIK your solution would run the split index test for 1, 2, 3, and 4. I think that is too much. 1 runs the fastest and I would like to keep it that way to get a quick "general" result. I think only 2 should be extended in the way you are suggesting. We could run the tests with different env variables there. What else do we have besides GIT_TEST_SPLIT_INDEX? Would that work for everyone? - Lars > ci/run-tests.sh | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ci/run-tests.sh b/ci/run-tests.sh > index f0c743de94..15a5f5a6cc 100755 > --- a/ci/run-tests.sh > +++ b/ci/run-tests.sh > @@ -8,3 +8,4 @@ > mkdir -p $HOME/travis-cache > ln -s $HOME/travis-cache/.prove t/.prove > make --quiet test > +GIT_TEST_SPLIT_INDEX=LetsTryIt make --quiet test
