On Fri, Dec 08, 2017 at 04:08:19PM +0100, Johannes Schindelin wrote: > > Yes, but test-lib.sh sources GIT-BUILD-OPTIONS, which we > > built during the first "make". And that overrides the > > environment, giving us the original SHELL_PATH again. > > ... and we could simply see whether the environment variable > TEST_SHELL_PATH (which we would set in t/Makefile from the passed-in > SHELL_PATH) is set, and override it again. > > I still think we can do without recording test-phase details in the > build-phase (which may, or may not, know what the test-phase wants to do). > > In other words, I believe that we can make the invocation you mentioned > above work, by touching only t/Makefile (to pass SHELL_PATH as > TEST_SHELL_PATH) and t/test-lib.sh (to override the SHELL_PATH from > GIT-BUILD-OPTIONS with TEST_SHELL_PATH, if set). We could do that, but it makes TEST_SHELL_PATH inconsistent with all of the other config.mak variables. -Peff
