On Fri, 25 May 2007, Junio C Hamano wrote: > "Dana How" <danahow@xxxxxxxxx> writes: > > >> * You already have the size here, so if min_blob_size is set > >> and the size is larger, you do not even have to call > >> write_sha1_file() at all. > > The way I read the code, it looks like unpack-objects needs > > the last argument always to be initialized with the SHA-1 computed > > from the object contents. Therefore I always need to call > > write_sha1_file(), even if I don't want it to write anything. > > Ah, that is what I missed. > > There is a separate function to only hash, named (surprisingly) > "hash_sha1_file(). Maybe you can teach the caller's "don't > write it out" codepath to call it. That would be clearer indeed. Nicolas - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
