Re: [PATCH v2 5/7] diff: use skip-to-optional-val in parsing --relative

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2 5/7] diff: use skip-to-optional-val in parsing --relative
From: Jeff King <peff@xxxxxxxx>
Date: Thu, 7 Dec 2017 16:11:03 -0500
Cc: git@xxxxxxxxxxxxxxx, christian.couder@xxxxxxxxx, jacob.e.keller@xxxxxxxxx
In-reply-to: <20171207173034.12865-2-gitster@pobox.com>
References: <20171207003517.11729-1-jacob.e.keller@intel.com> <20171207173034.12865-1-gitster@pobox.com> <20171207173034.12865-2-gitster@pobox.com>

On Thu, Dec 07, 2017 at 09:30:32AM -0800, Junio C Hamano wrote:

> Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx>
> ---

It might be worth mentioning why this conversion is pulled out from the
others (because its "default" case is "do not touch the pointer").

Other than that, it looks good to me.

-Peff

Follow-Ups:
- Re: [PATCH v2 5/7] diff: use skip-to-optional-val in parsing --relative
  - From: Junio C Hamano

References:
- [PATCH] diff: add test showing regression to --relative
  - From: Jacob Keller
- [PATCH v2 0/7] reroll of cc/skip-to-optional-val
  - From: Junio C Hamano
- [PATCH v2 5/7] diff: use skip-to-optional-val in parsing --relative
  - From: Junio C Hamano

Prev by Date: Re: What's cooking in git.git (Dec 2017, #01; Mon, 4)
Next by Date: Re: What's cooking in git.git (Dec 2017, #01; Mon, 4)
Previous by thread: Re: [PATCH v2 5/7] diff: use skip-to-optional-val in parsing --relative
Next by thread: Re: [PATCH v2 5/7] diff: use skip-to-optional-val in parsing --relative
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]

Powered by Linux