On Thu, Dec 7, 2017 at 1:18 AM, Jacob Keller <jacob.keller@xxxxxxxxx> wrote: > On Wed, Dec 6, 2017 at 4:16 PM, Jacob Keller <jacob.keller@xxxxxxxxx> wrote: >> >> This causes a regression in the --relative option which prevents it >> from working properly. >> >> If I have a repository with a modified file in a subdirectory, such as: >> >> a/file >> >> then git diff-index --relative --name-only HEAD from within "a" will >> return "a/file" instead of "file" >> >> This breaks git completion, (among other things). Ok, thanks for the report. I will fix that. > I believe this occurs because skip_to_optional_val overwrites the arg > even if it's not there, and the --relative argument expects prefix to > remain unchanged if the optional value is not provided. Yeah, that makes sense.
