On Fri, 25 May 2007, Joshua N Pritikin wrote: > On Fri, May 25, 2007 at 02:13:42PM +0100, Andy Parkins wrote: > > If a newline ever made it into an repository-side expanded $Id$ field, > > the keyword would still be detected as a keyword and collapsed, before > > rexpansion, e.g. > > > > $Id: all of this text would be removed, even if there > > were a newline in the middle of it$ > > > > This patch catches newlines in this case and abandons treating this as a > > keyword expansion, this text would be left untouched in the working > > checkout. > > That's better but I would error out instead of silently ignoring it. > Your choice. Erroring out in such a case would simply make the system too obnoxious. I don't think it is really worth aborting a commit just because you have a bad $Id:$ in one of your file. Nicolas - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
