Hi Junio, On 04 Dec 2017 18:58, Junio C Hamano wrote: > Robert Abel <rabel@xxxxxxxxxxxxx> writes: >> __git_eread is used to read a single line of a given file (if it exists) >> into a variable without the EOL. All six current users of __git_eread >> use it that way and don't expect multi-line content. > > Changing $@ to $2 does not change whether this is about "multi-line" > or not. I'm aware of that. I was documenting current usage. The function is used to read file contents (which are expected to be a single line) into _a_ (i.e. single) variable. None of the current users of the function expect tokens to be split, which is why I removed it in preparation of patch 2/2, which would break tokenizing file contents. Regards, Robert
