Jonathan Nieder wrote: > From: Johannes Schindelin <johannes.schindelin@xxxxxx> > Subject: git-gui: allow Ctrl+T to toggle multiple paths > > In the Unstaged Changes panel, selecting multiple lines (using > shift+click) and pressing ctrl+t to stage them causes one file to be > staged instead of all of the selected files. The same also happens > when unstaging files. > > This regression appears to have been introduced by gitgui-0.21.0~7^2~1 > (Allow keyboard control to work in the staging widgets, 2016-10-01). > > Also reported by zosrothko as a Git-for-Windows issue: > https://github.com/git-for-windows/git/issues/1012 > > [jn: fleshed out commit message] > > Reported-by: Timon <timon37@xxxxxxxxx> > Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx> > Signed-off-by: Jonathan Nieder <jrn@xxxxxxxxxx> Gah, this should say: Signed-off-by; Jonathan Nieder <jrnieder@xxxxxxxxx> [...] >> I applied it locally to git-2.15.0 and can confirm it fixed the problem for me. >> If you need any more info/help from me, or would like me to test >> anything, feel free to ask. > > Thanks for this pointer. I'm including the patch here so the project > can consider applying it (it doesn't appear to have been sent upstream > before). I have not tested it or verified the claim it makes about > what change introduced this regression --- if you're able to help with > that, that would be welcome. Can you bisect? That is: git clone git://repo.or.cz/git-gui cd git-gui git bisect start git bisect good gitgui-0.20.0 git bisect bad gitgui-0.21.0 Then cut to the chase: git checkout gitgui-0.21.0~7^2~1 ... test test test ... git bisect (good|bad) git checkout gitgui-0.21.0~7^2~1^ ... test test test ... git bisect (good|bad) and follow the instructions if it suggests testing additional versions. Then I'll be happy to re-send the patch with the results from your testing. Thanks again, Jonathan
