Re: [PATCH 2/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Todd Zullinger wrote:

> Much better, thank you.  How about this for the full commit message:
>
>    t/lib-git-svn.sh: improve svnserve tests with parallel make test
>
>    Setting SVNSERVE_PORT enables several tests which require a local
>    svnserve daemon to be run (in t9113 & t9126).  The tests share setup of
>    the local svnserve via `start_svnserve()`.  The function uses svnserve's
>    `--listen-once` option, which causes svnserve to accept one connection
>    on the port, serve it, and exit.  When running the tests in parallel
>    this fails if one test tries to start svnserve while the other is still
>    running.
>
>    Use the test number as the svnserve port (similar to httpd tests) to
>    avoid port conflicts.  Developers can set GIT_TEST_SVNSERVE to any value
>    other than 'false' or 'auto' to enable these tests.
>
> ?

Yep, with this description it is
Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx>

Thanks for putting up with my nits. :)

Jonathan



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux