Todd Zullinger <tmz@xxxxxxxxx> writes: > I pulled the travis docker image used in clang/gcc builds[1] and can > see it has both tcl and tk packages installed. The linux32 builds use > a docker image[2] which does not contain tcl or tk. > > [1] travisci/ci-garnet:packer-1503972846 > [2] daald/ubuntu32:xenial > > If we wanted, we could set BYPASS_TCLTK_CHECK only for the linux32 > builds. I think it's probably better to do it globally rather than > rely on the travis containers implicitly having tcl/tk installed. > >> The patch looks good to me. Thanks! >> >> I wonder if it would be better to squash it into my patch or to keep >> it separate. I am ok with both ways. > > I fine either way too. This is still just on pu, so squashing it in > seems like the way to go. I only made it separate to cause travis to > run the tests. :) I am OK either way but this may be giving an early warning that a typical mix of packages installed on a box will lead many people to encounter this glitch in the real world, and we may need a more seamless solution than a workaround. Keeping this "fix" separate from the original commit that introduced the issue would allow us more easily to refer real users who will be hit by this glitch to it, telling them to do something similar to their build environment.
