On Sun, Nov 26, 2017 at 6:43 PM, Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> wrote: > > > On 26/11/17 14:00, Christian Couder wrote: >> On Sun, Nov 26, 2017 at 4:53 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >>> Christian Couder <christian.couder@xxxxxxxxx> writes: >>> >>>> On Mon, Nov 20, 2017 at 6:15 PM, Christian Couder >>>> <christian.couder@xxxxxxxxx> wrote: >>>>> By default running `make install` in the root directory of the >>>>> project will set TCLTK_PATH to `wish` and then go into the "git-gui" >>>>> and "gitk-git" sub-directories to build and install these 2 >>>>> sub-projects. >>>> >>>> Has this patch fallen through the cracks or is there an unresolved issue? >>> >>> I had an impression that the conclusion was that the existing error >>> message at runtime already does an adequate job and there is no >>> issue to be addressed by this patch. Am I mistaken? >> >> This patch is mostly about what happens at the build step. Its goal is >> not much to improve what happens at runtime, though that is improved a >> bit too. If the build step was good enough, then I would agree that >> what happens at run time is adequate. >> >> Let's consider only people installing git using "make install" to use >> it on their machine, as I think I already discussed the case of >> packagers and added the BYPASS_TCLTK_CHECK variable for them. >> > > I haven't been following this thread too closely, but I have the > feeling that the best course of action is to simply not fall back > to using a tcl version of msgfmt in the first place!. ;-) Well, another possibility would be to try to use the tcl version of msgfmt in the build of git itself if msgfmt is not available. This way the build behavior of git and git-gui could be similar. > If a given platform does not have gettext/msgfmt, then you just > don't get an i18n-ed version of git. (no need for BYPASS_ ...). Right now without gettext/msgfmt you get an error unless you set NO_GETTEXT. If we try to use the tcl version of msgfmt in the build of git itself, then you could still get an i18n-ed version of git if you have Tcl/Tk. But anyway even if this is related, I think it is a different issue. > Am I missing something? I still think it is not the best outcome to just install git-gui and gitk by default when Tcl/Tk is not installed. In general it is best to fix potential errors at build time rather than at run time (even if the run time error is adequate).
