Max Kirillov <max@xxxxxxxxxx> writes:
> http-backend reads whole input until EOF. However, the RFC 3875 specifies
> that a script must read only as many bytes as specified by CONTENT_LENGTH
> environment variable. This causes hang under IIS/Windows, for example.
>
> Make http-backend read only CONTENT_LENGTH bytes, if it's defined, rather than
> the whole input until EOF. If the varibale is not defined, keep older behavior
> of reading until EOF because it is used to support chunked transfer-encoding.
>
> Signed-off-by: Florian Manschwetus <manschwetus@xxxxxxxxxxxxxxxxxxx>
> Authored-by: Florian Manschwetus <manschwetus@xxxxxxxxxxxxxxxxxxx>
> Fixed-by: Max Kirillov <max@xxxxxxxxxx>
> Signed-off-by: Max Kirillov <max@xxxxxxxxxx>
> ---
> ...
> I hope I marked it correctly in the trailers.
It is probably more conventional to do it like so:
From: Florian Manschwetus <manschwetus@xxxxxxxxxxxxxxxxxxx>
Date: <original date of Florian's patch series>
http-backend reads whole input until EOF. However, the RFC 3875...
... chunked transfer-encoding.
Signed-off-by: Florian Manschwetus <manschwetus@xxxxxxxxxxxxxxxxxxx>
[mk: fixed trivial build failures and stuff]
Signed-off-by: Max Kirillov <max@xxxxxxxxxx>
---
>
> +/*
> + * replacement for original read_request, now renamed to read_request_eof,
> + * honoring given content_length (req_len),
> + * provided by new wrapper function read_request
> + */
I agree with Eric's suggestion. In-code comment is read by those
who have the current code, without knowing/caring what it used to
be. "It used to do this, but replace it with this new thing
because..." is a valuable thing to record in the log message, but
not here.
