On Wed, Nov 22, 2017 at 04:08:39PM -0800, Jonathan Nieder wrote: > > For the record, I'm totally fine with banning assert() in favor of a > > custom equivalent. I just don't think we've seen any real problems with > > assert in our codebase so far. > > It sounds like we basically agree, then. :) Yeah, I didn't quite understand your argument at first. If it's that asserts are potentially dangerous, I buy that. They haven't bit us, but they could. That would be a good thing for Stefan to put in his commit message. ;) -Peff
