On Tue, Nov 21, 2017 at 12:58 PM, Jeff Hostetler <git@xxxxxxxxxxxxxxxxx> wrote: > + assert(arg); > + assert(!unset); I count 16 asserts in this patch. Is that really needed? Either omit them or use BUG if we want to rely on user bug reports when these conditions trigger, as assert is unreliable due to its dependence on the NDEBUG flag. Stefan
