On Tue, Nov 21, 2017 at 11:50 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Junio C Hamano <gitster@xxxxxxxxx> writes: > >> "brian m. carlson" <sandals@xxxxxxxxxxxxxxxxxxxx> writes: >> >>> This is a series proposing a basic abstraction for hash functions. >>> >>> The full description of the series can be found here: >>> https://public-inbox.org/git/20171028181239.59458-1-sandals@xxxxxxxxxxxxxxxxxxxx/ >>> >>> At the bottom of this message is the output of git tbdiff between v2 and >>> v3. >>> >>> Changes from v2: >>> * Remove inline. >>> * Add dummy functions that call die for unknown hash implementation. >>> * Move structure definitions to hash.h and include git-compat-util.h in >>> hash.h. >>> * Rename current_hash to the_hash_algo. >>> * Use repo_set_hash_algo everywhere we set the hash algorithm for a >>> struct repository. >> >> Change for all of the above in this series looked sensible to me. >> Thank, will queue. > > So... is everybody happy enough with this version that nobody minds > more codebase to be adjusted on the infrastructure this series lays > out? I think this is ready for 'next', but just in case I missed > some discussions... yeah I was happy at the time of review; sorry for not saying so.
