Jonathan Tan <jonathantanmy@xxxxxxxxxx> writes: >> Jeff Hostetler (6): >> dir: allow exclusions from blob in addition to file >> oidmap: add oidmap iterator methods >> oidset: add iterator methods to oidset >> list-objects: filter objects in traverse_commit_list >> rev-list: add list-objects filtering support >> pack-objects: add list-objects filtering > > I checked the diff against v4 and this looks good. > > I'm still unsure if pre-parsing the --filter argument into a struct > list_objects_filter_options is the best approach API-wise in the case > that we plan to send it to the server, but it does have the benefit of > failing (and informing the user) early if the filter is in the wrong > format, so I'm fine with this patch set as-is. Thanks. I share the same suspicion but as long as we keep the raw version in addition to the parsed-out value, we could pass it around without having to reconstruct it (and risking an incorrect reconstruction), so it should be OK. Will queue with your reviewed-by: unless you object ;-) Thanks, both.
