On Tue, Nov 21, 2017 at 10:14 PM, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > The erroring out in this case looks like simple oversight. Most > likely, this particular case did not occur to Duy. The code does > intentionally check the directory to see if it is dirty so that it can > warn the user (in which case the user can re-run with --force or take > other corrective action), but erroring out if the directory is merely "...erroring out if the directory _is missing_ is merely..." > an indirect (and unintended) result of trying to check for dirtiness. > > So, Kaatic's patch is intended to address that oversight (though I > haven't examined the implementation closely; I was just trying to > understand the reason for the patch).
