On 21/11/17 01:06, Junio C Hamano wrote:
> Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> writes:
>
>> Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx>
>> ---
>>
>> Hi Miklos,
>>
>> If you need to re-roll your 'mv/cherry-pick-s' branch, could you
>> please squash this into the relevant patch (commit 5ed75e2a3f,
>> "cherry-pick: don't forget -s on failure", 14-09-2017).
>
> What automated procedure are you using to produce these comments?
Err, no automated procedure, hence the idiocy ... :(
> The commit is from 14-09-2012, not from a few months ago, and is
> part of Git 1.8.0 and upwards, which won't be rerolled. Please add
> a check to see if the culprit is already in 'next' or something.
Yes, sorry, I wasn't paying attention. The actual commit which caused
the 'static-check.pl' script to bark, was d0aaa46fd3 ("commit: move empty
message checks to libgit", 10-11-2017) in the 'pu' branch. This commit
removes the last use of 'sign_off_header' outside of sequencer.c (from
builtin/commit.c).
> Will queue as _your_ fix, not a potential squash into another
> commit.
The above commit is in the 'pw/sequencer-in-process-commit' branch.
Sorry for the confusion. (Sorry Miklos).
> Thanks, as always, for your attention to detail.
Ahem. :D
ATB,
Ramsay Jones
