In particular, sparse complains that the armor_{en,de}code_arg()
functions are 'not declared - should they be static?'. Since the
armor_decode_arg() symbol does not require more than file visibility,
we can simply mark the declaration with static. The armor_encode_arg()
function has no callers, so we simply remove the (unused) definition.
Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx>
---
Hi Jeff,
If you need to re-roll your 'jh/object-filtering' branch, could you
please squash this (or something like it) into the relevant patch
(commit bf0aedcbe1, "list-objects: filter objects in traverse_commit_list",
16-11-2017).
Thanks!
ATB,
Ramsay Jones
list-objects-filter-options.c | 14 +-------------
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/list-objects-filter-options.c b/list-objects-filter-options.c
index 0e4ad70ab..bdbadd5a3 100644
--- a/list-objects-filter-options.c
+++ b/list-objects-filter-options.c
@@ -34,19 +34,7 @@ static int arg_needs_armor(const char *arg)
return 0;
}
-void armor_encode_arg(struct strbuf *buf, const char *arg)
-{
- static const char hex[] = "0123456789abcdef";
- const unsigned char *p;
-
- for (p = (const unsigned char *)arg; *p; p++) {
- unsigned int val = *p;
- strbuf_addch(buf, hex[val >> 4]);
- strbuf_addch(buf, hex[val & 0xf]);
- }
-}
-
-int armor_decode_arg(struct strbuf *buf, const char *arg)
+static int armor_decode_arg(struct strbuf *buf, const char *arg)
{
const char *p;
--
2.15.0
