gennady.kupava@xxxxxxxxx writes: > Subject: Re: [PATCH 1/2] Simplify tracing code by removing trace key normalization concept The usual style comment on the subject applies here. > From: Gennady Kupava <gkupava@xxxxxxxxxxxxx> > > - to implement efficient traces with normalization, normalization > implementation should be moved to header. as it seems better to not > overload header file with this normalization logic, suggestion is > just to remove it > - different macro exist specifically to handle traces with default key > - there is no use of normalization in current code > - it could be reintroduced if necessary I cannot quite tell what it is trying to achive to make it a bulleted list. It's not like four things at the same conceptual level is enumerated; instead it just has four sentences that talk about random things. More importantly, I am not sure I understand what these sentences are trying to say. "Should be moved to header"---so? Does that move something from the source to the header? It seems to me that the patch removes a helper function from trace.c but does not add anything to the header. Or am I wasting everybody's time by commenting on a stale comment that used to describe an ancient iteration of this code? Puzzled.
