Lars Schneider <larsxschneider@xxxxxxxxx> writes: >> On 16 Nov 2017, at 15:58, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> >> Lars Schneider <larsxschneider@xxxxxxxxx> writes: >> >>>> On 16 Nov 2017, at 07:04, Junio C Hamano <gitster@xxxxxxxxx> wrote: >>> >>> Wow. Thanks for the quick patch :-) >> >> Heh, this is not exactly my itch, so if you are inclined to, can you >> take it over from here on? > > Absolutely! What is the proper way to proceed here? Should I send a v2 > with the changes I suggested? How do I attribute you correctly? I > assume I need to remove your 'Signed-off-by:'? If you are making major changes over the original patch, you'd probably want to take the authorship and mention me on Helped-by: and/or add "This is based on a previous work by...", if you want to credit me. If you are not taking the authorship over, then doing something like https://public-inbox.org/git/xmqqshdex0ff.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxxx/ would be sufficient, I would think. Thanks.