On 16 November 2017 at 11:43, Phillip Wood <phillip.wood@xxxxxxxxxxxx> wrote: > On 15/11/17 18:44, Martin Ågren wrote: >> >> On 15 November 2017 at 11:41, Phillip Wood <phillip.wood@xxxxxxxxxxxx> >> wrote: >> >> From the commit message, I would have expected the flags to be zero. This >> patch >> does not only turn off the die-ing, it also tells the lockfile-API to >> print an >> error message before returning. I don't have an opinion on whether that >> extra >> verboseness is good or bad, but if it's wanted, I think the commit message >> should mention this change. > > > Hi Martin, thanks for your comments. LOCK_DIE_ON_ERROR also prints the same > warning so that behavior is unchanged by this patch, though mentioning it in > the commit message would be no bad thing. Argh, you're right of course. Sorry for this. Martin
