On Mon, Nov 13, 2017 at 9:30 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Elijah Newren <newren@xxxxxxxxx> writes: > >> + entry = dir_rename_find_entry(dir_renames, old_dir); >> + if (!entry) { >> + entry = xcalloc(1, sizeof(struct dir_rename_entry)); >> + hashmap_entry_init(entry, strhash(old_dir)); > > Please make these two lines into its own dir_rename_entry_init() > helper. <snip> > we'd want to see its string_list member to be > initialised explicitly Will do.