On 2017-11-14 01:21 AM, Christian Couder wrote:
On Tue, Nov 14, 2017 at 3:04 AM, <hsed@xxxxxxxxxxxx> wrote:
From: Haaris <hsed@xxxxxxxxxxxx>
Description:
This patch adds a new option to the config command.
Uses flag --expiry-date as a data-type to covert date-strings to
timestamps when reading from config files (GET).
This flag is ignored on write (SET) because the date-string is stored in
config without performing any normalization.
Creates a few test cases and documentation since its a new feature.
Motivation:
A parse_expiry_date() function already existed for api calls,
this patch simply allows the function to be used from the command line.
Signed-off-by: Haaris <hsed@xxxxxxxxxxxx>
Documentation/SubmittingPatches contains the following:
"Also notice that a real name is used in the Signed-off-by: line. Please
don't hide your real name."
And there is the following example before that:
Signed-off-by: Random J Developer <random@xxxxxxxxxxxxxxxxxxxxx>
So it looks like "a real name" actually means "a real firstname and a
real surname".
It would be nice if your "Signed-off-by:" could match this format.
It might already match that format if Haaris lives in a society that
only uses single names.
Still, such names are unusual enough that it's good to check that new
contributors are following the guidelines properly.
M.
Also if you have a "From:" line at the beginning of the patch, please
make sure that the name there is tha same as on the "Signed-off-by:".
Thanks for working on this,
Christian.
