On Mon, Nov 13, 2017 at 08:01:12AM +0530, Kaartic Sivaraam wrote: > On Sunday 12 November 2017 11:53 PM, Kevin Daudt wrote: > > On Thu, Nov 02, 2017 at 12:24:07PM +0530, Kaartic Sivaraam wrote: > > > From: Kaartic Sivaraam <kaarticsivaraam91196@xxxxxxxxx> > > > > > > When trying to rename an inexistent branch to with a name of a branch > > > > This sentence does not read well. Probably s/with a/the/ helps. > > > > Thanks. Seems I missed it somehow. Will fix it. > > > > that already exists the rename failed specifying the new branch name > > > exists rather than specifying that the branch trying to be renamed > > > doesn't exist. > > > > > > [..] > > > > > > Note: Thanks to the strbuf API that made it possible to easily construct > > > the composite error message strings! > > > > I'm not sure this note adds a lot, since the strbuf API is not that new. > > > > That was a little attribution I wanted make to the strbuf API as this was > the first time I leveraged it to this extent and I was surprised by the way > it made string manipulation easier in C. Just documented my excitation. In > case it seems to be noise (?) which should removed, let me know. I guess that would fit better below the the ---
