Thanks for the feedback! >> * Add bash completion for the missing --no-* options on git log >> * Add bash completion for --textconv and --indent-heuristic families to >> git diff and all commands that use diff's options >> * Add bash completion for --no-abbrev-commit, --expand-tabs, and >> --no-expand-tabs to git show > > This describes what happens in this patch, but not why, which helps > future readers of commit message more than the "what". How about: > Teach git-log tab completion about the --no-* options for ease of use > at the command line. > > Similarly, teach git-show tab completion about the --no-abbrev-commit, > --expand-tabs, and --no-expand-tabs options. > > Also, teach git-diff (and all commands that use its options) tab > completion about the --textconv and --indent-heuristic families of > options. --indent-heuristic is no longer experimental, so there's no > reason it should be left out of tab completion any more, and textconv > seems to have simply been missed. > At the end of a commit message, the Git project requires a sign off. > (See section (5) in Documentation/SubmittingPatches; > tl;dr: add Signed-off-by: NAME <EMAIL> if you can agree to > https://developercertificate.org/) So the sign-off should include my name and email? I thought it was supposed to be the person who approved the patch, but I must've gotten confused. > The patch looks good, but doesn't apply because the email contains > white spaces instead of tabs. Maybe try https://submitgit.herokuapp.com/ > (or fix/change your email client to send a patch; the gmail web interface > doesn't work. I personally got 'git send-email' up and running; > The Documentation/SubmittingPatches has a section on email clients, too) Yeah, I was using the gmail interface. I'll give the heroku app a go. It has an option for sending a message in reply to another, and I assume I should send it in reply to this thread. Do you know how to tell what the appropriate ID to use is? Looking through the raw email, I see several, so it's not obvious to me which to use. Thanks, Max
