On 07/11/17 03:03, Junio C Hamano wrote: > Phillip Wood <phillip.wood@xxxxxxxxxxxx> writes: > >> From: Phillip Wood <phillip.wood@xxxxxxxxxxxxx> >> >> Move run_rewrite_hook() from bulitin/commit.c to sequencer.c so it can >> be shared with other commands and add a new function >> commit_post_rewrite() based on the code in builtin/commit.c that >> encapsulates rewriting notes and running the post-rewrite hook. > > This, especially the part that rips out the notes rewriting from > builtin/commit.c and moves it to elsewhere, is a bit curious > separation of labor. I guess we'll see why in later steps in the > series. It's so the sequencer can have a built in version of 'git commit --amend' when processing fixup/squash commands. I'll expand the commit message to explain why this is needed later. > The change itself looks like a regression-free no-op, which is good. >
