On 11/01/2017 09:18 AM, Martin Ågren wrote: > On 28 October 2017 at 11:49, Michael Haggerty <mhagger@xxxxxxxxxxxx> wrote: >> The constants used for `ref_update::flags` were rather disorganized: > >> * The documentation wasn't very consistent and partly still referred >> to sha1s rather than oids. > >> @@ -478,22 +462,23 @@ struct ref_transaction *ref_transaction_begin(struct strbuf *err); >> * >> * refname -- the name of the reference to be affected. >> * >> - * new_sha1 -- the SHA-1 that should be set to be the new value of >> + * new_oid -- the SHA-1 that should be set to be the new value of >> * the reference. Some functions allow this parameter to be >> * NULL, meaning that the reference is not changed, or >> - * null_sha1, meaning that the reference should be deleted. A >> + * null_oid, meaning that the reference should be deleted. A >> * copy of this value is made in the transaction. >> * >> - * old_sha1 -- the SHA-1 value that the reference must have before >> + * old_oid -- the SHA-1 value that the reference must have before > > You still refer to "SHA-1" twice in this hunk. Maybe squash this in, at > least partially? This addresses all remaining "sha"/"SHA" in refs.h. > [...] Thanks for this. I'll squash the changes that have to do with these flags into this commit, and change the other docstrings as part of a separate commit that also fixes up similar problems in other refs-related comments. I also realized that `write_packed_entry()` still takes `unsigned char *` arguments. I'll fix that, too, in yet another commit. Thanks, Michael
