What version should include this fix? Cannot find a pr for it. Thanks for providing the fix! Regards, Yaroslav On Thu, Nov 2, 2017 at 3:48 PM, Yaroslav Sapozhnyk <yaroslav.sapozhnik@xxxxxxxxx> wrote: > I've tested the code change locally and seems like it fixes the issue. > > Yaroslav > > On Thu, Nov 2, 2017 at 2:55 PM, Dennis Kaarsemaker > <dennis@xxxxxxxxxxxxxxx> wrote: >> On Thu, 2017-11-02 at 11:35 -0700, Stefan Beller wrote: >>> On Thu, Nov 2, 2017 at 9:00 AM, Yaroslav Sapozhnyk >>> <yaroslav.sapozhnik@xxxxxxxxx> wrote: >>> > When using Git on Fedora with locked password store >>> > credential-libsecret asks for username/password instead of displaying >>> > the unlock dialog. >>> >>> Git as packaged by Fedora or upstream Git (which version)? >> >> Looking at the code: current upstream git. Looking at the documentation >> for libsecret, this should fix it. I've not been able to test it >> though. >> >> diff --git a/contrib/credential/libsecret/git-credential-libsecret.c b/contrib/credential/libsecret/git-credential-libsecret.c >> index 4c56979d8a..b4750c9ee8 100644 >> --- a/contrib/credential/libsecret/git-credential-libsecret.c >> +++ b/contrib/credential/libsecret/git-credential-libsecret.c >> @@ -104,7 +104,7 @@ static int keyring_get(struct credential *c) >> items = secret_service_search_sync(service, >> SECRET_SCHEMA_COMPAT_NETWORK, >> attributes, >> - SECRET_SEARCH_LOAD_SECRETS, >> + SECRET_SEARCH_LOAD_SECRETS | SECRET_SEARCH_UNLOCK, >> NULL, >> &error); >> g_hash_table_unref(attributes); > > > > -- > Regards, > Yaroslav Sapozhnyk -- Regards, Yaroslav Sapozhnyk
