On Tue, Oct 31, 2017 at 11:19 AM, Brandon Williams <bmwill@xxxxxxxxxx> wrote: > Changes in v3: > * Now always pass struct diff_flags by reference and don't return the struct > but rather modify the passed in struct. > * Don't clear TEXTCONV_SET_VIA_CMDLINE when --no-textconv is passed > * added additional patches (set out separately before) to remove the macros > and change the struct members to lowercase I have reviewed this version and the functionality introduced looks good to me. My only nits were regarding style and typos. Thanks, Stefan
