Hi,
On Tue, 31 Oct 2017, Junio C Hamano wrote:
> Alex Vandiver <alexmv@xxxxxxxxxxx> writes:
>
> > diff --git a/fsmonitor.c b/fsmonitor.c
> > index 4ea44dcc6..417759224 100644
> > --- a/fsmonitor.c
> > +++ b/fsmonitor.c
> > @@ -49,20 +49,7 @@ int read_fsmonitor_extension(struct index_state *istate, const void *data,
> > ewah_free(fsmonitor_dirty);
> > return error("failed to parse ewah bitmap reading fsmonitor index extension");
> > }
> > -
> > - if (git_config_get_fsmonitor()) {
> > - /* Mark all entries valid */
> > - for (i = 0; i < istate->cache_nr; i++)
> > - istate->cache[i]->ce_flags |= CE_FSMONITOR_VALID;
> > -
> > - /* Mark all previously saved entries as dirty */
> > - ewah_each_bit(fsmonitor_dirty, fsmonitor_ewah_callback, istate);
> > -
> > - /* Now mark the untracked cache for fsmonitor usage */
> > - if (istate->untracked)
> > - istate->untracked->use_fsmonitor = 1;
> > - }
> > - ewah_free(fsmonitor_dirty);
> > + istate->fsmonitor_dirty = fsmonitor_dirty;
>
> This makes local variable "int i;" in this function unused and gets
> compiler warning.
... to which end we introduced the DEVELOPER flag to catch these: if you
call
make DEVELOPER=1
and compile with GCC or Clang, it will elevate such warnings to errors,
and we highly encourage contributors to build their patched source code
with said flag.
Thanks,
Johannes
