Junio C Hamano <gitster@xxxxxxxxx> writes: > Junio C Hamano <gitster@xxxxxxxxx> writes: > >> I still haven't brought myself to like the structure being passed by >> value and the singleton diff_flags_cleared thing, but I suspect that >> we may get used to them once we start using these. I dunno. > > Just bikeshedding, but I just had to prepare an evil merge to add a > new use of diff_flags_cleared to a codepath that evolved in a topic > still in flight, and realized that I really hate the name. Perhaps > I wouldn't have hated it so much if it were named diff_flags_none or > diff_flags_empty, I guess. As to the "passing by value" thing, as long as we have the _or() helper function, no sensible person will add anything but a bitfield into the structure, so I am fine with it.
