Hey Junio, On Fri, Oct 27, 2017 at 11:49 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Pranit Bauva <pranit.bauva@xxxxxxxxx> writes: > >> - bisect_write "$state" "$rev" >> + git bisect--helper --bisect-write "$state" "$rev" "$TERM_GOOD" "$TERM_BAD" || exit > > I can see why two extra "terms" parameters need to be passed to this > helper at this step; looking at patches around 4/8 and 6/8 where C > code can directly find out what words are used for GOOD and BAD, we > should be able to lose these two extra parameters from this helper > by internally making a call to get_terms() from bisect_write() ;-) Yes quite true, but then after converting bisect_skip() we can completely get rid of this line and then it won't be needed in the ported C code. PS: I have already ported that function but those patches are local as of now. Regards, Pranit Bauva
