As we learned some time ago, NTLM authentication happens by passing "empty credentials", i.e. 0-length usernames and passwords. However, when saved in the Windows Credential Manager, such usernames and passwords come back as null when reading the credential. Let's handle this. This patch series is a tender four years old and has been simmering in Git for Windows since version v1.8.4, so it is most likely mature enough (even at that young age) to enter core Git. Note: these days, Git for Windows prefers to use the Git Credential Manager for Windows instead, but the wincred code is still carried in Git's contrib/ and should be fixed there, too. Jakub Bereżański (2): t0302: check helper can handle empty credentials wincred: handle empty username/password correctly contrib/credential/wincred/git-credential-wincred.c | 10 ++++++++-- t/lib-credential.sh | 19 +++++++++++++++++++ 2 files changed, 27 insertions(+), 2 deletions(-) base-commit: cb5918aa0d50f50e83787f65c2ddc3dcb10159fe Published-As: https://github.com/dscho/git/releases/tag/jberezanski/wincred-sso-r2-v1 Fetch-It-Via: git fetch https://github.com/dscho/git jberezanski/wincred-sso-r2-v1 -- 2.15.0.windows.1
