On Sat, Oct 28, 2017 at 6:22 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> Some thoughts: >> * We may want to do a follow on patch to convert all the flags from being in >> uppercase to lower case. > > If and only if we do not use macros to set/clr/test, this makes a > lot of sense. Otherwise, probably not. The .touched_flags is used just once in the code base for just one flag. I wonder if we could get rid of touched_flags and instead introduce a new flag (FORCE_TEXT_CONV instead of ALLOW_TEXT_CONV set by cmd_show specifically) that will enable the special casing that is currently done via the touched_flags. Once we get rid of the special casing, we can get rid of the macros.
