Junio C Hamano <junkio@xxxxxxx> wrote: > Martin Waitz <tali@xxxxxxxxxxxxxx> writes: > > > On Mon, May 21, 2007 at 04:02:42PM -0700, Junio C Hamano wrote: > >> I had a feeling that some callers needed to be able to unsetenv > >> some. How would this patch help them, or are they outside of > >> the scope? > > > > At first I had the same objection but the putenv documentation > > told me that at least in glibc you can unsetenv by providing > > the variable name without a "=". > > I recall SysV putenv() does not remove "ENVNAME" without '=', and > http://www.opengroup.org/onlinepubs/000095399/functions/putenv.html > seems to say that as well. Are we overbuilding this thing? I thought this thread all started because we wanted to run a command in a subproject, and did not want the parent's GIT_* environment variables to confuse the subproject process when it started. That's a pretty simple concept: clear any GIT_* environment variable that can change behavior in the subproject. And almost everyone who is trying to use this API and alter the env wants exactly that - a subproject command. -- Shawn. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
