Hi Christian, On Thu, 19 Oct 2017, Christian Couder wrote: > Add Git/Packet.pm from parts of t0021/rot13-filter.pl > > perl/Git/Packet.pm | 118 ++++++++++++++++++++++++++++++++++++++++++++++++ This change, together with forcing t0021/rot13-filter.pl to use Git/Packet.pm, breaks the test suite on Windows: https://travis-ci.org/git/git/jobs/292461846 There are actually two problems, one of which is fixed by -- snip -- diff --git a/perl/Makefile b/perl/Makefile index 15d96fcc7a5..f657de20e39 100644 --- a/perl/Makefile +++ b/perl/Makefile @@ -30,6 +30,7 @@ instdir_SQ = $(subst ','\'',$(prefix)/lib) modules += Git modules += Git/I18N modules += Git/IndexInfo +modules += Git/Packet modules += Git/SVN modules += Git/SVN/Memoize/YAML modules += Git/SVN/Fetcher -- snap -- You will want to pick this up in the next iteration. (You simply did not notice because you did not build with NO_PERL_MAKEMAKER.) However, that *still* does not fix the test for me: note how in the verbose output recorded in Travis (see the link above), Perl fails to find the Perl modules and then says: Can't locate Git/Packet.pm in @INC (you may need to install the Git::Packet module) (@INC contains: C \BuildAgent\_work\5\s\perl\blib\lib;C \BuildAgent\_work\5\s\perl\blib\arch\auto\Git /usr/lib/perl5/site_perl [..] Note that the correct blib path starts with `C:\BuildAgent\_work` and the line use lib (split(/:/, $ENV{GITPERLLIB})); splits off the drive letter from the rest of the path. Obviously, this fails to Do The Right Thing, and simply points to Yet Another Portability Problem with Git's reliance on Unix scripting. But why is it a Windows path in the first place? We take pains at using only Unix-style paths in Git's test suite after all. Well, this one is easy. We call git.exe, which is a pure Win32 executable (i.e. it *wants* Windows paths, even in the environment passed to it) and git.exe in turn calls Perl to interpret rot13-filter.pl. So on the way to git.exe, GITPERLLIB is converted by the MSYS2 runtime into a Windows-style path list. And then it is not converted back when we call Perl. As a workaround, I used a trick to exclude GITPERLLIB from being converted by MSYS2: setting the environment variable MSYS2_ENV_CONV_EXCL=GITPERLLIB "fixed" the test for me (with above patch thrown in). I also set the test in the Visual Studio Team Services build definition that runs those tests triggered by Travis. If your patch makes it into Git's `master`, we may have to hardcode that MSYS2_ENV_CONV_EXCL=GITPERLLIB (or augment any existing MSYS2_ENV_CONV_EXCL), so that other Windows developers do not have to stumble over the same thing and then spend 3 hours to debug it. Ciao, Dscho
