Re: [PATCH] merge-recursive: check GIT_MERGE_VERBOSITY only once

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH] merge-recursive: check GIT_MERGE_VERBOSITY only once
From: Andrey Okoshkin <a.okoshkin@xxxxxxxxxxx>
Date: Wed, 25 Oct 2017 13:49:50 +0300
Cc: "git@xxxxxxxxxxxxxxx" <git@xxxxxxxxxxxxxxx>, vmiklos@xxxxxxxxxxxxxx, Jeff King <peff@xxxxxxxx>, Junio C Hamano <gitster@xxxxxxxxx>
Cms-type: 101P
In-reply-to: <CAPig+cRTL2amjsgdp1=T3GMZLa=favugOfnQw9XjWzC+U=v5Sw@mail.gmail.com>
Organization: Samsung RnD Institute Russia
References: <CGME20171024152727epcas2p4fb7dcf147e44aadf7733098151d469a5@epcas2p4.samsung.com> <3aed764b-388c-d163-08fc-32b294c6b9d3@samsung.com> <CAGZ79kaSZG9WriqX0SLbTnEDRr-4YdFRuK17+9wnxyrftfnMmg@mail.gmail.com> <CAPig+cRTL2amjsgdp1=T3GMZLa=favugOfnQw9XjWzC+U=v5Sw@mail.gmail.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0

24.10.2017 19:45, Eric Sunshine wrote:
> I feel uncomfortable about this change, not due to lack of thread
> safety, but due to the distance between the getenv() invocation and
> its point of use. See below for more detail.

Thanks, the usage must be just after the assignment.

-- 
Best regards,
Andrey Okoshkin

References:
- [PATCH] merge-recursive: check GIT_MERGE_VERBOSITY only once
  - From: Andrey Okoshkin
- Re: [PATCH] merge-recursive: check GIT_MERGE_VERBOSITY only once
  - From: Stefan Beller
- Re: [PATCH] merge-recursive: check GIT_MERGE_VERBOSITY only once
  - From: Eric Sunshine

Prev by Date: Re: [PATCH] merge-recursive: check GIT_MERGE_VERBOSITY only once
Next by Date: Re: [PATCH] merge-recursive: check GIT_MERGE_VERBOSITY only once
Previous by thread: Re: [PATCH] merge-recursive: check GIT_MERGE_VERBOSITY only once
Next by thread: Re: [PATCH] merge-recursive: check GIT_MERGE_VERBOSITY only once
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]