Junio wrote: > * I was hoping that the next_byte() and string_hash() thing, once > they are cleaned up, will eventually be shared with the xdiff/ > code at the lower layer, which needs to do pretty much the same > in order to implement various whitespace ignoring options. I am > not sure how well the approach taken by the WIP patch meshes with > the needs of the lower layer. This series does exactly this; although I chose to reuse the code in xdiff/xutils.c instead of the new fancy next_byte/string_hash, as that code has seen more exercise already (hence I assume it has fewer bugs if any as well as its performance implications are well understood). However to do so, we need to pollute xdiff/xutils.c and include hashmap.h there (which also requires cache.h as that header has an inline function using BUG()), which I find a bit unfortunate but worth the trade off of using better tested code. Thanks, Stefan Stefan Beller (4): hashmap: introduce memhash_feed to access the internals of FNV-1 hash xdiff-interface: export comparing and hashing strings xdiff: use stronger hash function internally diff.c: get rid of duplicate implementation diff.c | 82 +++---------------------------------------------------- hashmap.c | 7 ++++- hashmap.h | 3 ++ xdiff-interface.c | 11 ++++++++ xdiff-interface.h | 5 ++++ xdiff/xutils.c | 19 ++++++------- 6 files changed, 37 insertions(+), 90 deletions(-) -- 2.15.0.rc2.6.g953226eb5f
