Hi Johannes, I fixed all the tests at that time, but another one was added that I could not figure out how to fix. I was planning to break the commit up into smaller parts and only convert one stash command at a time calling them still from the shell script. I haven't had time to do that yet though. My latest change is here: https://github.com/klusark/git/tree/rfc-c-stash The test commits have already been merged, so just the last two are needed. I haven't been keeping history of my changes, although I have sent it to the mailing list around 4 times. Joel On Mon, Oct 23, 2017 at 4:09 AM, Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > Hi Joel, > > On Sun, 28 May 2017, Joel Teichroeb wrote: > >> I've rewritten git stash as a builtin c command. All tests pass, >> and I've added two new tests. Test coverage is around 95% with the >> only things missing coverage being error handlers. > > I am embarrassed to say that I never found the time to have a detailed > look at this, and it has been 5 months since you sent this. Sorry about > that. > > Do you have an easy-to-fetch branch with this somewhere? > > Thanks, > Dscho
