Re: [PATCH v3 0/3] deprecate git stash save

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff King <peff@xxxxxxxx> writes:

> On Mon, Oct 23, 2017 at 10:19:38AM +0900, Junio C Hamano wrote:
>
>> > -	This option is deprecated in favour of 'git stash push'.
>> > +	This option is deprecated in favour of 'git stash push'.  It
>> > +	differs from "stash push" in that it cannot take pathspecs,
>> > +	and any non-option arguments form the message.
>> 
>> Every time I saw this line, I misread s/form/from/ and got
>> confused.
>
> We could reverse the order:
>
>    ...and the message is taken from any non-option arguments.

Yeah, that makes it slightly less confusing.  Or "any non-option
arguments become the message", perhaps?  I dunno.

Let's queue the version as posted; perhaps somebody new comes and
says it is confusing in three months, at which time we may be able
to come up with a better phrasing with a fresh mind ;-)




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux