Re: [PATCH] diff.c: increment buffer pointer in all code path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH] diff.c: increment buffer pointer in all code path
From: Stefan Beller <sbeller@xxxxxxxxxx>
Date: Thu, 19 Oct 2017 12:55:49 -0700
Cc: Junio C Hamano <gitster@xxxxxxxxx>, "git@xxxxxxxxxxxxxxx" <git@xxxxxxxxxxxxxxx>, Orgad Shaneh <orgads@xxxxxxxxx>
In-reply-to: <20171019054246.jii62lq2druohbpo@sigill.intra.peff.net>
References: <20171012200536.m6oz4zrjcze3yw4i@sigill.intra.peff.net> <20171012233322.31203-1-sbeller@google.com> <20171013001837.43nx5paeqisbrflq@sigill.intra.peff.net> <20171013002057.froqi54olmhmah6b@sigill.intra.peff.net> <20171019050459.p2cx63yrxfwq4ta3@sigill.intra.peff.net> <20171019052457.gqenoshgyjcw53tb@sigill.intra.peff.net> <xmqqzi8niu1r.fsf@gitster.mtv.corp.google.com> <20171019054246.jii62lq2druohbpo@sigill.intra.peff.net>

On Wed, Oct 18, 2017 at 10:42 PM, Jeff King <peff@xxxxxxxx> wrote:

>
> So I think the right fix is this:
>
[...]
>
> It's late here, so I'll wait for comments from Stefan and then try to
> wrap it up with a commit message and test tomorrow.
>
> -Peff

I agree that this is better and looks correct.
Thanks for offering to send a patch. I'd be happy to review it.

Thanks,
Stefan

References:
- Re: Out of memory with diff.colormoved enabled
  - From: Jeff King
- [PATCH] diff.c: increment buffer pointer in all code path
  - From: Stefan Beller
- Re: [PATCH] diff.c: increment buffer pointer in all code path
  - From: Jeff King
- Re: [PATCH] diff.c: increment buffer pointer in all code path
  - From: Jeff King
- Re: [PATCH] diff.c: increment buffer pointer in all code path
  - From: Jeff King
- Re: [PATCH] diff.c: increment buffer pointer in all code path
  - From: Jeff King
- Re: [PATCH] diff.c: increment buffer pointer in all code path
  - From: Junio C Hamano
- Re: [PATCH] diff.c: increment buffer pointer in all code path
  - From: Jeff King

Prev by Date: [PATCH] add a test for "describe --contains" with mixed tags
Next by Date: Re: [PATCH] diff.c: increment buffer pointer in all code path
Previous by thread: Re: [PATCH] diff.c: increment buffer pointer in all code path
Next by thread: [PATCH 0/5] fix "diff --color-moved --ignore-space-at-eol"
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]