On Wed, Oct 18, 2017 at 12:55 PM, Guillaume Castagnino <casta+github@xxxxxxxxxx> wrote: > From: Guillaume Castagnino <casta@xxxxxxxxxx> > > as stated in comment in https://github.com/git/git/commit/46a13857fc036b54ac2ddd0a218e5cc171aa7bd9#diff-00703a794a540acf45e225abd6aeda3b the referenced commit is broken when using ACL and not basic UNIX rights. > this commit handle ACL too Thanks for contributing to Git! Please see Documentation/SubmittingPatches for details, tl;dr: * If you can legally agree with https://developercertificate.org/ add a line "Signed-off-by: NAME <email>" * Please give a more descriptive commit message. Usually we phrase the commit subject as "area: do thing", you have the "do thing" part, but the area is unclear. Maybe: gitweb: use filetest to allow ACLs * Keep the message text roughly at 70 characters per line, as that is easier to read in e.g. git-show. * Instead of linking to github, we usually only refer to the commit, e.g. In commit 46a1385 (gitweb: skip unreadable subdirectories, 2017-07-18) we forgot to handle non-unix ACLs as well. Fix this. * Do we need a test/documentation for this? Thanks, Stefan > --- > gitweb/gitweb.perl | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl > index 9208f42ed1753..0ee7f304ce2b1 100755 > --- a/gitweb/gitweb.perl > +++ b/gitweb/gitweb.perl > @@ -3072,6 +3072,7 @@ sub git_get_projects_list { > # only directories can be git repositories > return unless (-d $_); > # need search permission > + use filetest 'access'; > return unless (-x $_); > # don't traverse too deep (Find is super slow on os x) > # $project_maxdepth excludes depth of $projectroot > > -- > https://github.com/git/git/pull/416
