On Thu, Oct 12, 2017 at 4:10 PM, Jeff King <peff@xxxxxxxx> wrote: > On Thu, Oct 12, 2017 at 04:06:11PM -0400, Jeffrey Walton wrote: > >> I have a script to build Git on some old platforms to ease testing. >> Old platforms include CentOS 5. The script is available at >> https://github.com/noloader/Build-Scripts/blob/master/build-ssh.sh. >> >> It looks like something got knocked loose recently. I'm seeing several >> of these when building with PCRE 8.41 with Git 2.14.2. Old and new >> platforms are witnessing it. I observe it on CentOS 5 with GCC 4.1; >> and Fedora 26 with GCC 7.2. >> >> ... >> LINK git-credential-store >> libgit.a(grep.o): In function `pcre1match': >> grep.c:(.text+0x1219): undefined reference to `pcre_jit_exec' >> collect2: error: ld returned 1 exit status >> make: *** [Makefile:2145: git-credential-store] Error 1 > > Maybe: > > $ git grep -h -B5 -A1 pcre_jit Makefile > # When using USE_LIBPCRE1, define NO_LIBPCRE1_JIT if the PCRE v1 > # library is compiled without --enable-jit. We will auto-detect > # whether the version of the PCRE v1 library in use has JIT support at > # all, but we unfortunately can't auto-detect whether JIT support > # hasn't been compiled in in an otherwise JIT-supporting version. If > # you have link-time errors about a missing `pcre_jit_exec` define > # this, or recompile PCRE v1 with --enable-jit. Ah, thanks. A quick search did not find that comment. And it did not occur to me to re-run --help to read about it. > It looks like autoconf turns on USE_LIBPCRE1, but isn't smart enough to > test NO_LIBPCRE1_JIT. If Git wants Jit, then I am inclined to configure PCRE to provide it. A quick question if you happen to know... Does PCRE Jit cause a loss of NX-stacks? If it causes a loss of NX-stacks, then I think I prefer to disable it. Jeff
