On 10 October 2017 at 16:01, Jeff King <peff@xxxxxxxx> wrote: > On Tue, Oct 10, 2017 at 12:30:49PM +0200, Martin Ågren wrote: >> On 9 October 2017 at 23:45, Kevin Daudt <me@xxxxxxxxx> wrote: >> > Since ff1e72483 (tag: change default of `pager.tag` to "on", >> > 2017-08-02), the pager has been enabled by default, exposing this >> > problem to more people. >> >> Oh. :( I didn't know about "column" to be honest. > > Yeah, I didn't think of that with respect to the pager. This is a > regression in v2.14.2, I think. Yes. >> In any case, it might make sense to test an >> actual use-case also. Of course, the code should be largely the same, >> but in builtin/tag.c, it's quite important that `setup_auto_pager()` >> and `finalize_colopts()` are called in the right order. > > I think it might work out either way. If we have started the pager when > we finalize_colopts(), then the pager_in_use() bit will kick in. If we > haven't, then either: > > 1. stdout is a tty, and we'll kick in the auto behavior for columns, > and then later for the pager. > > 2. stdout isn't a tty, in which case we also won't kick in the pager. Right you are.
