On Tue, Oct 10, 2017 at 05:25:43AM -0400, Jeff King wrote: > On Tue, Oct 10, 2017 at 11:23:19AM +0200, Simon Ruderich wrote: >> On Tue, Oct 10, 2017 at 09:00:09AM +0900, Junio C Hamano wrote: >>>> --- a/entry.c >>>> +++ b/entry.c >>>> @@ -283,6 +283,7 @@ static int write_entry(struct cache_entry *ce, >>>> if (dco && dco->state != CE_NO_DELAY) { >>>> /* Do not send the blob in case of a retry. */ >>>> if (dco->state == CE_RETRY) { >>>> + free(new); >>>> new = NULL; >>>> size = 0; >>>> } >> >> FREE_AND_NULL(new)? > > Ah, yeah, I forgot we had that now. It would work here, but note that > this code ends up going away later in the series. Ah sorry, missed that. Then never mind. Regards Simon -- + privacy is necessary + using gnupg http://gnupg.org + public key id: 0x92FEFDB7E44C32F9