These two patches are for a recent #leftoverbits topic. https://public-inbox.org/git/xmqqr2vlbgyk.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxxx/ The cmd_foo() function is a moral equivalent of 'main' for a Git subcommand 'git foo', and as such, it is allowed to do many things that make it unsuitable to be called as a subroutine, including - call exit(3) to terminate the process; - allocate resource held and used throughout its lifetime, without releasing it upon return/exit; - rely on global variables being initialized at program startup, and update them as needed, making another clean invocation of the function impossible. Correcting two callers by using helper API calls is not so hard. Junio C Hamano (2): describe: do not use cmd_*() as a subroutine merge-ours: do not use cmd_*() as a subroutine builtin/describe.c | 15 +++++++++++---- builtin/merge-ours.c | 16 +++++++--------- 2 files changed, 18 insertions(+), 13 deletions(-) -- 2.15.0-rc0-203-g4c8d0e28b1
