Stefan Beller wrote: > This way users of this function do not need to read the implementation to > know what it will do. > > Signed-off-by: Jonathan Nieder <jrnieder@xxxxxxxxx> > Signed-off-by: Stefan Beller <sbeller@xxxxxxxxxx> > --- > submodule.c | 5 ----- > submodule.h | 18 ++++++++++++++++++ > 2 files changed, 18 insertions(+), 5 deletions(-) Looks good (well, you'd expect me to think that :)). Thanks.