On Fri, Oct 6, 2017 at 3:32 PM, Heiko Voigt <hvoigt@xxxxxxxxxx> wrote: > NOTE: The argument in this message is not correct, see description in > cover letter. > > The setup of the repositories in this test is using gitlinks without the > .gitmodules infrastructure. It is however testing convenience features > like --recurse-submodules=on-demand. These features are already not > supported by fetch without a .gitmodules file. This leads us to the > conclusion that it is not really used here as well. > > Let's use the usual submodule commands to setup the repository in a > typical way. This also has the advantage that we are testing with a > repository structure that is more similar to one we could expect on a > users setup. > > Signed-off-by: Heiko Voigt <hvoigt@xxxxxxxxxx> > --- > > As mentioned in the cover letter. This seems to be the only test that > ensures that we stay compatible with setups without .gitmodules. Maybe > we should add/revive some? An interesting discussion covering this topic is found at https://public-inbox.org/git/20170606035650.oykbz2uc4xkr3cr2@xxxxxxxxxxxxxxxxxxxxx/