On 6 October 2017 at 11:40, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Simon Ruderich <simon@xxxxxxxxxxxx> writes: > >> Did you consider Stefan Beller's suggestion regarding a >> (white)list of allowed versions? >> >> On Mon, Sep 18, 2017 at 01:06:59PM -0700, Stefan Beller wrote: >>> Thinking about this, how about: >>> >>> If not configured, we do as we want. (i.e. Git has full control over >>> it's decision making process, which for now is "favor v0 over v1 as >>> we are experimenting with v1". This strategy may change in the future >>> to "prefer highest version number that both client and server can speak".) >>> >>> If it is configured, "use highest configured number from the given set". >>> >>> ? >> >> It would also allow the server operator to configure only a >> specific set of versions (to handle the "version x is >> insecure/slow"-issue raised by Stefan Beller). The current code >> always uses the latest protocol supported by the git binary. > > If we do anything less trivial than "highest supported by both" (and > I suspect we want to in the final production version), I'd prefer > the configuration to list versions one side supports in decreasing > order of preference (e.g. "v3 v0 v2"), and take the earliest from > this list that both sides know how to talk, so that we can skip > insecure versions altogether by omitting, and we can express that we > would rather avoid talking expensive versions unless there is no > other version that is understood by the other side. Maybe I'm missing something Git-specific, but isn't the only thing that needs to be done now, to document/specify that 1) the client should send its list ordered by preference, 2) how preference is signalled, and 3) that the server gets to choose? Why would a server operator with only v0 and v1 at their disposal want to choose v0 instead of v1, considering that -- as far as I understand -- they are in fact the same? Different server implementations and different server configurations will be able to apply whatever rules they want in order to decide which version to use. (It's not like the client can verify the choice that the server makes.) And Brandon's "pick the highest number" will do for now. There are many possible rules that the server could apply and they shouldn't affect other servers or what the client does. For example, the server can go "You seem to know lots of versions, including X and Y. Those are the two that I really prefer, but between those two I'm not picky, so I'll use whichever of X and Y that you seem to prefer." Unless I've missed something, we'll never need to implement -- nor specify -- anything like that before we have learned both v2 and v3. I guess my thinking is, there's a difference between the protocol and the implementation. Martin
